Clean up running CI processes when killed #1207
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This should make restarting CI processes on Mac much more reliable, as Nomad cannot reliably kill the whole tree itself there. This should also solve the annoyance of CI jobs leaving behind running build containers when they are killed. The behaviour relies on any long-running processes in the CI scripts being wrapped in a short_timeout or long_timeout call, which I think they all are.
TimoWilken
force-pushed
the
ci-kill-process-group
branch
from
9e5354b
to
21956e3
Compare
TimoWilken
added a commit
to TimoWilken/ali-bot
that referenced
this pull request
Nov 7, 2022
This conflicts with the change in alisw#1207.
|
So far, this doesn't fail when run in normal operation on Linux, but I want to test this change on Mac (and test the behaviour when killed, as well, not just normal operation) before this can be merged. |
ktf
pushed a commit
that referenced
this pull request
Nov 7, 2022
This conflicts with the change in #1207.
|
Found a problem with this on the M1 Mac: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should make restarting CI processes on Mac much more reliable, as Nomad cannot reliably kill the whole tree itself there. This should also solve the annoyance of CI jobs leaving behind running build containers when they are killed.
The behaviour relies on any long-running processes in the CI scripts being wrapped in a short_timeout or long_timeout call, which I think they all are.
Draft because I've not tested this yet.